-
Notifications
You must be signed in to change notification settings - Fork 15.2k
update docker image (busybox) #50360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
jayeshmahajan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking a time in finding this and raising PR.
| ```shell | ||
| kubectl run curl --image=radial/busyboxplus:curl -i --tty --rm | ||
| kubectl run -i --tty --image busybox:1.37 dns-test --restart=Never --rm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to even hardcode the version. May be just go with this to avoid future version fix.
kubectl run -i --tty --image busybox dns-test --restart=Never --rm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a general question: you can save yourself the hassle of updating the versions, but it may cause problems in the future if the image is changed. In a tutorial it's maybe better without a version. Is there a general rule how it should be implemented on this website?
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Updated the docker image radial/busyboxplus:curl to busybox:1.37
Don't know if it's suitable to run the nslookup command. Therefore please check it during the review and maybe adjust it to solve the issue described below.
Issue
The docker image radial/busyboxplus:curl was not updated for long time. Therefore when running the command mentioned in the tutorial, I get this error (with RKE2, server version v1.31.6+rke2r1):